Optimize server latency#2886
Merged
Merged
Conversation
Contributor
|
看起来改动比较大。是不是重点保证“耗时不包括用户回调的时间”这个就可以？为了实现“耗时包括异步写的response的时间”要增加很多复杂度，包括新引入一个bthread_id，而且可能导致用户升级后观察到的server latency比之前长，容易引起困扰 |
Contributor
Author
|
或者只在span中实现“耗时包括异步写的response的时间“？这样对于排查网络因素导致发送慢response了的问题，应该还是有意义的。 |
Contributor
这样也可以 |
chenBright
force-pushed
the
server_latency
branch
2 times, most recently
from
ca045d5 to
86f6795
Compare
Contributor
Author
done |
Contributor
|
LGTM |
chenBright
force-pushed
the
server_latency
branch
from
86f6795 to
6a0a761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #2437
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: